Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IPv6 by default #79

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Use IPv6 by default #79

merged 2 commits into from
Feb 21, 2023

Conversation

simonmicro
Copy link

@simonmicro simonmicro commented Dec 7, 2022 •
edited

This will listen to IPv6 by default, as well as create dual-stack sockets by default.

Linux Kernels, which have IPv6 removed / disabled won't be able to start the py-kms server anymore, without explicitly changing the listen_addr as well as the dual-parameter.

Closes #71

Remaining steps

  • Test on real IPv6-hardware (both bare+Docker)

@simonmicro simonmicro added the fix This fixed a bug - do not forget to mention the correcsponding issue. label Dec 7, 2022
@simonmicro simonmicro self-assigned this Dec 7, 2022
@Matthew-Beckett Matthew-Beckett mentioned this pull request Jan 6, 2023
Closed
@Matthew-Beckett
Copy link
Collaborator

Pending testing, asked requester on #71 to test.

@DerEnderKeks
Copy link

I tested this with ghcr.io/py-kms-organization/py-kms:latest@sha256:3b8cb6871cbfc5ae9a76909d53f0d659af28fbe5abb3b9d075c1b33c95813804 in my K8s cluster and it works on IPv6 without having to manually override the IP env var 👍 (Can't say if IPv4 still works, as that is not used in my setup)

@simonmicro simonmicro changed the base branch from master to next February 21, 2023 13:05
@simonmicro
Copy link
Author

Let's go beta!

@simonmicro simonmicro merged commit fe7784d into next Feb 21, 2023
@simonmicro simonmicro deleted the feature/ipv6_default branch February 21, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matthew-Beckett Matthew-Beckett Awaiting requested review from Matthew-Beckett

Assignees

@simonmicro simonmicro

Labels
fix This fixed a bug - do not forget to mention the correcsponding issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use dual-stack by default
3 participants
@simonmicro @Matthew-Beckett @DerEnderKeks