Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move requirements from Dockerfile to txt file. #67 #68

Merged
merged 3 commits into from
May 29, 2022
Merged

move requirements from Dockerfile to txt file. #67 #68

merged 3 commits into from
May 29, 2022

Conversation

edgd1er
Copy link

@edgd1er edgd1er commented Apr 22, 2022

Suggest an implementation for request #67

  • move requirements from Dockerfile to requirements.txt
  • import sqlite_web as pypi package
  • change tz through python
  • conditionnal import for sqlite_web in minimal container.

@simonmicro simonmicro self-requested a review May 1, 2022 19:08
simonmicro
simonmicro requested changes May 1, 2022
View reviewed changes
Copy link

@simonmicro simonmicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially the modification of the sudoers file is critical! Please checkout my comments - do not hesitate to correct me if I'm wrong.

Otherwise thanks for your work and time!

docker/entrypoint.py Show resolved Hide resolved
docker/requirements.txt Outdated Show resolved Hide resolved
docker/start.py Outdated Show resolved Hide resolved
docker/start.py Outdated Show resolved Hide resolved
@simonmicro simonmicro self-assigned this May 1, 2022
@simonmicro simonmicro added the enhancement New feature or request label May 1, 2022
@simonmicro simonmicro mentioned this pull request May 1, 2022
Closed
@edgd1er
Copy link
Author

edgd1er commented May 13, 2022

removed import in start.py + rebase.

@simonmicro
Copy link

As this PR is against our master branch, could you verify that it also works for you @Matthew-Beckett ? It runs for me, but just to be sure 😁

@simonmicro
Copy link

I'm going to merge this now - lets hope nothing breaks :P

@simonmicro simonmicro merged commit 1435c86 into Py-KMS-Organization:master May 29, 2022
@edgd1er edgd1er deleted the req branch June 1, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonmicro simonmicro simonmicro approved these changes

@Matthew-Beckett Matthew-Beckett Awaiting requested review from Matthew-Beckett

Assignees

@simonmicro simonmicro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgd1er @simonmicro