-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on GitHub Actions #596
Conversation
we should either drop python 2 or add python 2 to this PR and delete the other providers |
I've got another branch ready to drop Python 2.7, 3.4 and 3.5. Shall I merge it in here, or add 2.7 to this, or wait for this to be merged then open a new PR? |
Updated to do this, and also added 3.5. (Python 3.4 isn't available on GHA.) I think it'll be better to have separate PRs, as the other one is quite big. It also means the GHA config would already merged into master, which is needed to enable it for this repo. |
Ha, AppVeyor fails with no |
Co-authored-by: Anthony Sottile <asottile@umich.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/test.yml
Outdated
run: python -m pip install -U tox | ||
|
||
- name: Tox tests | ||
shell: bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line can be removed too
Travis CI has a new pricing model which places limits on open source.
Many projects are moving to GitHub Actions instead, which provides testing on Linux, macOS and Windows, with 20 parallel jobs (compared to 5 on Travis and 1 on AppVeyor).
This PR adds testing for modern Python 3.6-3.9 and PyPy3 on the three operating systems. I didn't bother with EOL Pythons here.
Here's an example run:
Note PyPy3/Windows is excluded for the time being, we're waiting for GHA to include the latest PyPy3 release:
I also didn't remove Travis CI or AppVeyor here, but I would suggest doing so.