Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking spy_ema.csv EMA14 data doesn't break tests ComparesAgainstExternalData and ComparesAgainstExternalDataAfterReset #8146

Closed
4 tasks done
femtotrader opened this issue Jul 5, 2024 · 0 comments · Fixed by #8153

Comments

@femtotrader
Copy link
Contributor

femtotrader commented Jul 5, 2024

Expected Behavior

When changing data in EMA14 column with fake (wrong) values, tests should fail but they are still passing correctly.

Actual Behavior

The 2 tests in ExponentialMovingAverageTests

  • ComparesAgainstExternalData
  • ComparesAgainstExternalDataAfterReset

are passing successfully... even if data in EMA14 column are wrong

Potential Solution

should be discussed

Reproducing the Problem

Change content of spy_ema.csv file

from

760113000,46.8125,45.71432142857143
762532200,44.59375,45.56491190476191

to

760113000,46.8125,99945.71432142857143
762532200,44.59375,99945.56491190476191

Run ExponentialMovingAverageTests...
they are still passing ! (which is problematic)

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant