Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily run failure: Unit tests #816

Closed
github-actions bot opened this issue Jul 3, 2024 · 4 comments
Closed

Daily run failure: Unit tests #816

github-actions bot opened this issue Jul 3, 2024 · 4 comments
Assignees
@MarcAntoineSchmidtQC
Labels
[bot] Daily run

Comments

@github-actions
Copy link

github-actions bot commented Jul 3, 2024

The daily unit tests failed. See https://github.com/Quantco/glum/actions/runs/9772131161 for details.
@MarcAntoineSchmidtQC
Copy link
Member

Most likely due to the tabmat refactoring here: Quantco/tabmat#370

@MarcAntoineSchmidtQC
Copy link
Member

MarcAntoineSchmidtQC commented Jul 3, 2024 •
edited
Loading

nevermind, it was just a temporary issue.

@MarcAntoineSchmidtQC
Copy link
Member

The problem comes from this line (and the logic around it).

We should revert back to using column indices, not names.

@lbittarello
Copy link
Member

Happy to revert the change. That said, repeated column names are rare enough that, if it were up to me, I'd rather just raise an error and keep the code leaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC

Labels
[bot] Daily run
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lbittarello @MarcAntoineSchmidtQC