Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New importLocale prop for I18nProviderClient missing on documentation #327

Closed
maloyuso opened this issue Jan 8, 2024 · 1 comment · Fixed by #329 or #331
Closed

New importLocale prop for I18nProviderClient missing on documentation #327

maloyuso opened this issue Jan 8, 2024 · 1 comment · Fixed by #329 or #331
Labels
bug Something isn't working

Comments

@maloyuso
Copy link

maloyuso commented Jan 8, 2024

Describe the bug
A new required prop was added to I18nProviderClient but there's no documentation on whats the expected value. Also useScopedI18n stops working.

To Reproduce
Steps to reproduce the behavior:

  1. Mounting
  2. An error is raised: Property 'importLocale' is missing in type '{ children: Element; locale: "en"; fallback: Element; }' but required in type '{ locale: string; fallback?: ReactNode; importLocale: Promise<Record<string, unknown>>; children: ReactNode; }
  3. useScopedI18n stops working. The passed scope is not being recognized

Expected behavior
There's no error on I18nProviderClient and useScopedI18n works as expected.

Screenshots
NA

About (please complete the following information):

  • next-international version 1.2.0
  • Next.js version 14.0.1

Additional context
Issue when trying to update to next-international version 1.2.0

@QuiiBz
Copy link
Owner

QuiiBz commented Jan 8, 2024

https://github.com/QuiiBz/next-international/releases/tag/1.2.1 was released to fix the types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants