Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should prepare_sector_split() only run when apply_sector_split = TRUE? #174

Open
cjyetman opened this issue Oct 17, 2024 · 0 comments
Open

Comments

@cjyetman
Copy link
Member

cjyetman commented Oct 17, 2024

consider whether either...

in prepare_abcd(), prepare_sector_split() should only run conditionally if apply_sector_split = TRUE in the config

prepare_sector_split(config)

or if prepare_sector_split() should test that apply_sector_split = TRUE in the config and otherwise exit out immediately

(or both)

As it is now, prepare_abcd() will always run prepare_sector_split(), and prepare_sector_split() will error if the sector split CSV is not found even if apply_sector_split = FALSE in the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant