-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestions for prepare_for_timeline() #145
Comments
Also, there's no |
So, now I understand that the |
also, it's not super clear that if you do not specify
|
Thanks @cjyetman for your feedback. In principle I did not adjust the code of the plots yet to be usable for investor output (see #24 ) as banks' have priority for the CRAN release and as I don't have test data for investors output. But I guess that @maurolepore has already tried to solve some of the issues that you mention so maybe at least this chart will be usable for investors in this release. We should definitely adjust the parameters description for 'sector_filter'. First for catching that! |
I was trying to use
prepare_for_timeline()
with investor data. Here are a few things I noticed/desired...sector_filter
argument allows one to explicitly list the sectors they want, but I would like a way to specify all sectors without having to the each one out.sector_filter
argument matches a set of sector names that do not exist in invest data (e.g. investor data hasAviation
notaviation
), so it's impossible to use without modifying all the sector names in my data to match these.prepare_for_timeline()
The text was updated successfully, but these errors were encountered: