Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenAPI schema to implement new operations #1564

Closed
dkoslicki opened this issue Jul 12, 2021 · 8 comments
Closed

Update OpenAPI schema to implement new operations #1564

dkoslicki opened this issue Jul 12, 2021 · 8 comments
Assignees

Comments

@dkoslicki
Copy link
Member

@finnagin work with @edeutsch to figure out how to change this file (if that's even the right one) to properly advertise which operations we have implemented.

Bonus points if this can be done automatically any time operation_to_ARAXi.py is updated.

@edeutsch
Copy link
Collaborator

Yes, this is basically the correct file, although it is a template for code generation is not the actual live file. The live file lives a bit deeper down. Do we have the schema definitions for each of these workflows? I am on vacation and am trying to keep up but not managing very well.

@finnagin
Copy link
Member

@edeutsch by schema definitions do you mean these?

@finnagin
Copy link
Member

@edeutsch Just following up on this now that you are back from vacation. Was the OW repo definitions what you meant by the schema definitions?

@edeutsch
Copy link
Collaborator

Thanks for the reminder, Finn, the answer is yes.

I started the update, but I think I am now blocked by this:
NCATSTranslator/OperationsAndWorkflows#44

I might be able to press ahead, but I'm fearing an explosion from the OpenAPI framework if I try to deploy it as is.

@dkoslicki
Copy link
Member Author

Removing Finn, but this issue is still relevant, since we implement some additional operations but don't advertise it. See here for the ones we implement

@dkoslicki dkoslicki assigned edeutsch and unassigned finnagin Jun 5, 2022
@dkoslicki
Copy link
Member Author

So assigning @edeutsch to updated the OpenAPI schema

@edeutsch
Copy link
Collaborator

edeutsch commented Jun 5, 2022

It looks to me like we are advertising exactly this list here:

operations:
- lookup
- lookup_and_score
- overlay_compute_ngd
- overlay_compute_jaccard
- overlay_fisher_exact_test
- overlay_connect_knodes
- filter_results_top_n
- bind
- fill
- filter_kgraph_orphans
- filter_kgraph_top_n
- filter_kgraph_std_dev
- filter_kgraph_percentile
- filter_kgraph_discrete_kedge_attribute
- filter_kgraph_continuous_kedge_attribute
- sort_results_score
- sort_results_edge_attribute
- sort_results_node_attribute
- annotate_nodes
- score
- complete_results

So I am thinking this is done? Agree and close? Or let me know what is missing?

@edeutsch
Copy link
Collaborator

This is already fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants