Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuesday's RHOBTB2 query #1666

Closed
edeutsch opened this issue Sep 20, 2021 · 2 comments
Closed

Tuesday's RHOBTB2 query #1666

edeutsch opened this issue Sep 20, 2021 · 2 comments
Assignees

Comments

@edeutsch
Copy link
Collaborator

I think this is a slight revisitation of a previous query. I didn't mention it before, but this time will:

https://github.com/NCATSTranslator/testing/pull/121/files#diff-81022c561b4ab80e31cf06c7a9aa42461fb7917a61d8adfb61e67435d1998cf5

In order results we return the name of NCBIGene:23221 as "Genetic locus associated with RHOBTB2"
https://arax.ncats.io/?term=NCBIGene:23221
I seem to recall that we programmically insert "Genetic locus associated with" in cases where the NCBIGene entity is named after a disease or something. I forget details now exactly, but I thought somehow we had some NCBIGene entries that were named something like "Huntington disease" and the gene would get conflated with the disease. And we concluded that the NCBIGene entry was really just an entry for the "Genetic locus associated with disease X"

But if this case it looks to me that a real gene is running afoul of this code gene X is getting turned into "Genetic locus associated with gene X" which is a little silly.

I don't know if this part of the code should be tweaked or if an exception should be made. This gene in particular has come up before in queries.

It might be useful to have an answer for this issue if we get called on it tomorrow.

@finnagin
Copy link
Member

finnagin commented Feb 2, 2022

@edeutsch is this issue okay to close?

@edeutsch
Copy link
Collaborator Author

yes, okay to close. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants