Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire DTD model in ARAX expand and ARAX overlay modules #2091

Closed
chunyuma opened this issue Aug 9, 2023 · 5 comments
Closed

Retire DTD model in ARAX expand and ARAX overlay modules #2091

chunyuma opened this issue Aug 9, 2023 · 5 comments

Comments

@chunyuma
Copy link
Collaborator

chunyuma commented Aug 9, 2023

Hi all,

As we discussed previously in one of our AHM meeting, it seems like people are now more interested in using xDTD (the creative mode) and seldomly use DTD model (the model without RL, the model mentioned in ARAX paper). I'm wondering if we can retire this model (please see this comments). Any objections about this idea.

@chunyuma chunyuma mentioned this issue Aug 9, 2023
90 tasks
@edeutsch
Copy link
Collaborator

edeutsch commented Aug 9, 2023

I have no objections and it seems very reasonable, but I don't really understand how ARAX is currently using DTD in queries.

@chunyuma
Copy link
Collaborator Author

chunyuma commented Aug 9, 2023

Hi @edeutsch, the old DTD is mainly used in ARAX expand and ARAX Overlay modules.

@chunyuma
Copy link
Collaborator Author

chunyuma commented Aug 9, 2023

I've merged the branch KG2.8.4c and retire_DTD. Now in the branch KG2.8.4c, the old DTD model has been retired.

@saramsey
Copy link
Member

@chunyuma: thank you! Can this issue be closed out then?

@saramsey
Copy link
Member

Just checking back on this @chunyuma ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants