Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on old boto library #413

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Remove dependency on old boto library #413

merged 2 commits into from
Jan 30, 2020

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Jan 25, 2020

Motivation

We don't really need boto as a dependency.
We weren't really using it, anyway.

Checklist

Before you create the PR, please make sure you have:

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Checked that all unit tests pass

@mpenkov mpenkov merged commit 2feb910 into piskvorky:master Jan 30, 2020
@mpenkov mpenkov deleted the boto branch January 30, 2020 03:54
isobit added a commit to isobit/smart_open that referenced this pull request Jul 20, 2020
@isobit
Remove boto as a dependency
ecce29e 
Fixes:
- piskvorky#391
- piskvorky#409

Related to:
- piskvorky#413
- piskvorky#468
- piskvorky#408
@isobit isobit mentioned this pull request Jul 20, 2020
Merged
mpenkov added a commit that referenced this pull request Aug 30, 2020
@isobit @mpenkov
Remove boto as a dependency (#523)
399e30e 
* Remove boto as a dependency

Fixes:
- #391
- #409

Related to:
- #413
- #468
- #408

* Remove old boto tests and remove boto as test dependency

* Remove mention of boto from README as tests are no longer in place

* update CHANGELOG.md

Co-authored-by: Michael Penkov <misha.penkov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mpenkov