Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Privilege escalation: Unquoted call to "crlfsuite-script.py" #4

Closed
ItsIgnacioPortal opened this issue Jul 17, 2022 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@ItsIgnacioPortal
Copy link

ItsIgnacioPortal commented Jul 17, 2022

Please see the readme of this project: https://github.com/ItsIgnacioPortal/Improper-Quotes-Monitor

TL;DR: CRLFsuite is vulnerable to privilege escalation because it tries to access a file without quotation marks. More specifically, when I run crlfsuite --help, python tries to run:

C:\Program Files\Python39\python.exe C:\Program Files\Python39\Scripts\crlfsuite-script.py --help

but because the path was not quoted properly, it actually runs:

C:\Program.exe Files\Python39\python.exe C:\Program Files\Python39\Scripts\crlfsuite-script.py --help

This vulnerability isn't super serious because crlfsuite doesn't need to be ran as Administrator at any point, and no "default" Windows configuration makes this exploitable. Old Windows versions (such as Windows 8.1) are still vulnerable though.

@Raghavd3v
Copy link
Owner

Raghavd3v commented Jul 17, 2022

Hi @ItsIgnacioPortal,
This issue doesn't need to be fixed due to its very low severity so we are closing this issue as wontfix.

@Raghavd3v Raghavd3v pinned this issue Jul 17, 2022
@Raghavd3v Raghavd3v unpinned this issue Jul 17, 2022
@Raghavd3v Raghavd3v added bug Something isn't working Priority: Urgent Critical bugs labels Jul 17, 2022
@Raghavd3v Raghavd3v added wontfix This will not be worked on and removed Priority: Urgent Critical bugs labels Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants