Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider quick fix for reuseSorting on data.frame-ish input #6505

Open
MichaelChirico opened this issue Sep 18, 2024 · 0 comments
Open

Reconsider quick fix for reuseSorting on data.frame-ish input #6505

MichaelChirico opened this issue Sep 18, 2024 · 0 comments
Labels
internals

Comments

@MichaelChirico
Copy link
Member 

          Interesting one, I don't have any better fix for now, we should probably start with understanding the issue better to figure out better fix.

Originally posted by @jangorecki in #6502 (comment)

#6502 has a fix, but I wasn't satisfied with it. It's weird that the error triggers on tbl_df/tbl/data.frame but not on plain data.frame.

It requires a bit closer look at the responsible bmerge code. A new solution will feel less hacky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelChirico