Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Materialize: Notification property incorrectly is exception rather than error for kind: "E" #2105

Closed
benlesh opened this issue Nov 5, 2016 · 1 comment · Fixed by #2106
Closed

Materialize: Notification property incorrectly is exception rather than error for kind: "E" #2105

benlesh opened this issue Nov 5, 2016 · 1 comment · Fixed by #2106
Assignees
@benlesh
Labels
bug Confirmed bug

Comments

@benlesh
Copy link
Member

benlesh commented Nov 5, 2016

RxJS version: 5.0.0-rc.1

Code to reproduce:

Rx.Observable.throw(new Error('sad'))
  .materialize()
  .map(n => n.error.message)
  .subscribe(x => console.log(x))

Expected behavior:
logs "sad"

Actual behavior:
Throws cannot read "message" of undefined

Additional information:
Currently error is in the exception field.

Required to upgrade falcor-router to Rx5
@benlesh benlesh self-assigned this Nov 5, 2016
@benlesh benlesh mentioned this issue Nov 5, 2016
Merged
jayphelps pushed a commit that referenced this issue Nov 5, 2016
@benlesh @jayphelps
fix(Notification): materialize output will now match Rx4 (#2106)
c83bab9 
- changed notification's `exception` property to by named `error`

BREAKING CHANGE: `Notification.prototype.exception` is now `Notification.prototype.error` to match Rx4 semantics

fixes #2105
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benlesh benlesh

Labels
bug Confirmed bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Notification): materialize output will now match Rx4
1 participant
@benlesh