Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rxjs): remove types.ts importing from itself. #3383

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

bowenni
Copy link
Contributor

@bowenni bowenni commented Mar 6, 2018

Description:
PartialObserver is defined in types.ts . Importing it again causes a build error in google3.

Related issue (if exists):

@rxjs-bot
Copy link

rxjs-bot commented Mar 6, 2018

Messages
📖

CJS: 1313.3KB, global: 698.6KB (gzipped: 114.5KB), min: 135.0KB (gzipped: 29.8KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.517% when pulling 1c8d557 on bowenni:patch-2 into 1e4ca05 on ReactiveX:master.

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants