fix(node/TS): eliminate incompatable types to protected properties #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue in Node and TypeScript where if a project had more than one copy of RxJS, even if it was the same version, types would be incompatable between say, Observable and Observable, due to protected fields in the dts files. As all of these fields are really implementation details of the library, and my be removed at any time do to architectural changes, it is prudent to mark them as deprecated. Marking them as public only serves to eliminate the type incompatibilities.
jasonaden
approved these changes
Apr 11, 2018
benlesh
added a commit
to benlesh/rxjs
that referenced
this pull request
Apr 11, 2018
This deprecates protected properties that users should not be using when extending types they probably should not be extending. This also makes them public, mostly so in situations where there are multiple copies of rxjs in in a node project, TypeScript is still happy with the resulting dts files related to ReactiveX#3544
benlesh
added a commit
that referenced
this pull request
Apr 11, 2018
… TS (#3546) This deprecates protected properties that users should not be using when extending types they probably should not be extending. This also makes them public, mostly so in situations where there are multiple copies of rxjs in in a node project, TypeScript is still happy with the resulting dts files related to #3544
ProbablePrime
added a commit
to mixer/cdk-std
that referenced
this pull request
Apr 18, 2018
A new version of RXJS marked these as public and not protected. See: ReactiveX/rxjs#3544
ProbablePrime
added a commit
to mixer/cdk-std
that referenced
this pull request
Apr 18, 2018
A new version of RXJS marked these as public and not protected. See: ReactiveX/rxjs#3544
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue in Node and TypeScript where if a project had more than one copy of RxJS, even if it was the same version, types would be incompatable between say, Observable and Observable, due to protected fields in the dts files. As all of these fields are really implementation details of the library, and my be removed at any time do to architectural changes, it is prudent to mark them as deprecated. Marking them as public only serves to eliminate the type incompatibilities.