diff --git a/src/main/java/io/reactivex/internal/operators/flowable/FlowableDoAfterNext.java b/src/main/java/io/reactivex/internal/operators/flowable/FlowableDoAfterNext.java index c847954050..cb7daf058c 100644 --- a/src/main/java/io/reactivex/internal/operators/flowable/FlowableDoAfterNext.java +++ b/src/main/java/io/reactivex/internal/operators/flowable/FlowableDoAfterNext.java @@ -55,6 +55,9 @@ static final class DoAfterSubscriber extends BasicFuseableSubscriber { @Override public void onNext(T t) { + if (done) { + return; + } actual.onNext(t); if (sourceMode == NONE) { diff --git a/src/test/java/io/reactivex/flowable/FlowableDoAfterNextTest.java b/src/test/java/io/reactivex/flowable/FlowableDoAfterNextTest.java new file mode 100644 index 0000000000..7a2a480943 --- /dev/null +++ b/src/test/java/io/reactivex/flowable/FlowableDoAfterNextTest.java @@ -0,0 +1,44 @@ +/** + * Copyright 2016 Netflix, Inc. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package io.reactivex.flowable; + +import static org.junit.Assert.assertEquals; + +import java.util.concurrent.atomic.AtomicInteger; + +import org.junit.Test; + +import io.reactivex.functions.Consumer; + +public class FlowableDoAfterNextTest { + + @Test + public void testIfFunctionThrowsThatNoMoreEventsAreProcessed() { + final AtomicInteger count = new AtomicInteger(); + final RuntimeException e = new RuntimeException(); + Burst.items(1, 2).create() + .doAfterNext(new Consumer() { + @Override + public void accept(Integer t) throws Exception { + count.incrementAndGet(); + throw e; + }}) + .test() + .assertError(e) + .assertValue(1); + assertEquals(1, count.get()); + } +}