Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag not shown if not in tagGroup #215

Closed
bartkummel opened this issue Feb 28, 2017 · 2 comments
Closed

Tag not shown if not in tagGroup #215

bartkummel opened this issue Feb 28, 2017 · 2 comments

Comments

@bartkummel
Copy link

When using the x-tagGroups feature, tags that are not in a tagGroup are not shown at all. I would at least expect a warning. But perhaps it is even better to create a default tagGroup automatically, where all ungrouped tags are added to implicitly.

@RomanHotsiy
Copy link
Member

@bartkummel there should be a warning in browser console saying which tags are not shown at all
image

Regarding default tagGroup, I do not thing it is a good solution because it it is not clear e.g. how to name it, where to put it (on the beginning or at the end). And I don't want to introduce options like defaultGroupTitle, defaultGroupPosition.

I will add warning not only to console but also to the top of the page. Do you think it would be an appropriate solution?

@bartkummel
Copy link
Author

I think adding a warning to the page is an appropriate solution. Perhaps it's a good idea to add a warning to the documentation as well, such as: "If you are going to use x-tagGroups, please make sure you add all tags to a group, since a tag that is not in a group, will not be displayed at all!"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants