Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Save persistant states asynchronously in auto-save #304

Open
Timongcraft opened this issue Apr 28, 2024 · 1 comment
Open

Comments

@Timongcraft
Copy link

Timongcraft commented Apr 28, 2024

Is your feature request related to a problem? Please describe.
When the auto-save is performed the persistent states (command storages used in /data ... storage) are saved which can cause significant lag when used heavily.

Describe the solution you'd like
It would like it to be saved asyncronously when performed in the auto-save so it won't lag out the server.

Describe alternatives you've considered

Additional context
I'm talking about the ServerWorld#saveLevel method which saves the persistant states synchronously.
This doesn't occour in paper due to their IO rewrite.(https://github.com/PaperMC/Paper/blob/f4c7d373e4a1aff23539fe099745bf29a28559b9/patches/server/0999-Write-SavedData-IO-async.patch#L79)
With the [ioSystem].replaceImpl you can't see this in spark reports but it still lags.

Mojang Ticket: https://bugs.mojang.com/browse/MC-270159

@PringlePot
Copy link

This would be great, since for some reason this lags my server a bunch (more than 5seconds for a single tick)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants