fix: Support new CWS URL #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made new capture group non-capturing (i.e. `(?:)`) because it would otherwise be the first capture group, but other parts of the code rely on hard coded capture group numbers (namely `[1]`)
|
Thanks for the PR, I'll merge it and add a small follow-up. |
Rob--W
added a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
Tested all changes in browser and web demo.
--
crxviewer/src/cws_pattern.js
Line 185 in e7ccd4f
No change needed here. CWS automatically redirects you to new CWS, only if you actually enabled the new CWS. So the current link is more of a permalink and will probably not be deprecated soon.