Ember 5 support?

[petenickless]

Hello,

Just wondering if there are any plans to upgrade this plugin for use with Ember 5?

Thanks

[RobbieTheWagner]

@petenickless is it not currently working with Ember 5?

[AmauryD]

We are using Ember 5 with embroider and we have no issue with ember flatpickr. Maybe you mean a V2 addon format ?

[petenickless]

Hey @AmauryD @RobbieTheWagner - thanks for getting back to me.

We're getting ERESOLVE unable to resolve dependency tree when running ember install ember-flatpickr

🚧  Installing packages... This might take a couple of minutes.
Command failed with exit code 1: npm install --save-dev --loglevel error ember-flatpickr
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: boma@0.0.0
npm ERR! Found: ember-source@5.4.0
npm ERR! node_modules/ember-source
npm ERR!   dev ember-source@"~5.4.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer ember-source@"^3.28.0 || ^4.0.0" from ember-flatpickr@4.0.0
npm ERR! node_modules/ember-flatpickr
npm ERR!   dev ember-flatpickr@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/pete/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/pete/.npm/_logs/2023-11-13T19_53_39_422Z-debug-0.log```

We're running ember-cli v5.4.0.  Are you guys up to date also?

Any help would be gratefully received.  

Thanks

[AmauryD]

@petenickless

The problem is from the dependency resolution. Ember-flatpickr allows Ember 3.x and Ember 4.x for its peerDependencies. Npm seems to be strict about this and throws an error because you have Ember 5 installed. I'll submit a pull request to fix this issue.

Because i'm not using pnpm in 'strict' mode, i only have a warning on my side.

[petenickless]

Thanks so much @AmauryD - very much appreciated.

[petenickless]

Very much appreciate your efficiency on this @RobbieTheWagner and @AmauryD. Thanks again.