-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Respects] Add type hints #634
Conversation
Fix unused constants and adjust imports to accommodate
Also fix formatting for tox check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I did a first pass, overall LGTM. Will let tatsu take a look as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. Just a few small things below.
Bypassing branch protections (branch out of date) because base branch changes are unrelated and squashing |
This resolves #633. It's meant to be compliant with the Python 3.8 type hints spec.