Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Respects] Add type hints #634

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

octtariv
Copy link

This resolves #633. It's meant to be compliant with the Python 3.8 type hints spec.

Fix unused constants and adjust imports to accommodate
Also fix formatting for tox check
Copy link
Member

@Injabie3 Injabie3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did a first pass, overall LGTM. Will let tatsu take a look as well.

cogs/respects/core.py Outdated Show resolved Hide resolved
Copy link
Member

@quachtridat quachtridat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Just a few small things below.

cogs/respects/constants.py Outdated Show resolved Hide resolved
cogs/respects/core.py Outdated Show resolved Hide resolved
cogs/respects/core.py Outdated Show resolved Hide resolved
@Injabie3
Copy link
Member

Injabie3 commented Apr 4, 2023

Bypassing branch protections (branch out of date) because base branch changes are unrelated and squashing

@Injabie3 Injabie3 merged commit e8d8d53 into SFUAnime:V3/testing Apr 4, 2023
@octtariv octtariv deleted the respects-type-hints branch April 6, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Respects] Add type hints
3 participants