Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for getStackTrace() and setStackTrace() #56

Open
kodoman opened this issue Nov 5, 2021 · 1 comment
Open

Support for getStackTrace() and setStackTrace() #56

kodoman opened this issue Nov 5, 2021 · 1 comment

Comments

@kodoman
Copy link

kodoman commented Nov 5, 2021

Hi Salomon,

We're in the process of integrating your plugin in our app.

It would be very beneficial to be able to manipulate the stack trace before sending the ANRError to Firebase Crashlytics, so we can group the ANR issues together in the console there. Crashlytics groups the issues based on the topmost frame in the stack trace, so we were thinking of adding a custom frame to the top to let Firebase know that it belongs next to other ANR issues.

I've tried using couple of methods inherited from Throwable, but they don't seem to be overriden in the ANRError class - getStackTrace() returns an empty array and setStackTrace() doesn't seem to do anything.

So my questions are:

  1. Is there a way to add a custom frame to the top of the stack trace in the ANRError?
  2. If not, do you plan to add the support for manipulating the stack trace of the ANRError?

BTW, thanks for creating this plugin and making it open-source! It's a lifesaver amidst the current shortage of ANR detectors 😃

@SalomonBrys
Copy link
Owner

I do not have time to maintain this, but please put together a PR, and I'll release a new version ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants