Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear the folder before/after upload #52

Closed
thebspin opened this issue Mar 24, 2020 · 6 comments · Fixed by #117
Closed

Clear the folder before/after upload #52

thebspin opened this issue Mar 24, 2020 · 6 comments · Fixed by #117

Comments

@thebspin
Copy link

I think this was possible in the past when you passed on the --delete arg? But this no longer seems to work and i can't find it back in the docs.

But when you build something with vue/react or any other js library as far as i know they give some files unique hashed names everytime. That means on every upload i'm having extra files i no longer need.

Is it possible to clear the folder before or preferably after? The later will need to see what files are new or changed and remove the rest i suppose. Where before will cause a small downtime.

@januszmarcinik
Copy link

Hi,
Try this action instead :)
It cleans destination folder first, each time when is executed.
https://github.com/marketplace/actions/deploy-app-by-ftp

@sdegetaus
Copy link

I am curious about this too

@SamKirkland
Copy link
Owner

Currently this library does not support deleting files unless those files exist in source control.
Like you said an older version of this library (v2.0.0) does this. You can use version 2.0.0 if you'd like. I'll look into re-adding this.

The only real disadvantage of v2 is the publish can take longer because it's not using git to determine what to publish (so it has to look at every file).

Also side-node some libraries delete all files before uploading starts. That's not an ideal solution because it causes downtime until the publish is complete.

Thanks.

@Zenoo
Copy link

Zenoo commented Jul 17, 2020

Deleting files deleted in commits would be great, I have to manually do it in Filezilla right now, which defeats the whole point ...

@baba43
Copy link

baba43 commented Aug 14, 2020

That would be a very nice and important feature.

Like @Zenoo said, this Action becomes quite useless if one has to clean up the target directory manually over time.

However, I'm thankful for the effort you've put into this project so far.

@SamKirkland SamKirkland mentioned this issue Nov 13, 2020
9 tasks
@SamKirkland SamKirkland linked a pull request Nov 13, 2020 that will close this issue
9 tasks
@SamKirkland
Copy link
Owner

version 4 will now sync all changes by default! woohoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants