Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node.js] On scalingo-18 this buildpack resolves Node.js to an incompatible version #42

Closed
johnsudaar opened this issue Apr 22, 2022 · 5 comments
Labels

Comments

@johnsudaar
Copy link

johnsudaar commented Apr 22, 2022

Node 18 broke the compatibility with Ubuntu 18.04 (used by our scalingo-18 stack) see: nodejs/node#42351

Currently any build done on scalingo-18 that needs Node.JS without freezing it to a version <= 17 are failing with the following error:

node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by node)

Related to SRE-443

@EtienneM EtienneM changed the title [Node.JS] On scalingo-18 this buildpack resolves Node.JS to an imcompatible version [Node.js] On scalingo-18 this buildpack resolves Node.js to an incompatible version Apr 22, 2022
@EtienneM EtienneM added the low label Apr 22, 2022
@EtienneM
Copy link
Member

EtienneM commented Apr 22, 2022

I can see the PHP buildpack uses a Semver server located at semver.io.

https://github.com/Scalingo/php-buildpack/blob/91b9bcb0ac487be86539826147a2621387ccf5fd/lib/nodejs#L39

Maybe part of the solution to this problem is to use our own Semver app (https://semver.scalingo.com/) so that we can control what it returns by default?

Or maybe the solution is to write a nice message in case we detect Node.js >= 18 and the stack scalingo-18 so that we display a nice error message?

@johnsudaar
Copy link
Author

It could be a good solution. Switch to https://semver.scalingo.io/node-$STACK/resolve/$SEMVER_RANGE and ensure that it resolved correctly (currently it doesn't).

I'm not found of the message. IMHO if the user doesn't specify any Node.JS version, we should resolve it correctly.

IMHO the fix is in 2 parts:

  1. use our semver (with the stacks)
  2. Fix our semver so that it doesn't resolve Node 18 on scalingo-18 stacks.

@brandon-welsch
Copy link
Member

@EtienneM EtienneM transferred this issue from Scalingo/php-buildpack Sep 30, 2022
@EtienneM
Copy link
Member

The path https://semver.scalingo.com/node-scalingo-18/versions shouldn't resolve versions > 16

@EtienneM EtienneM assigned EtienneM and unassigned EtienneM Oct 3, 2022
@ipfaze
Copy link

ipfaze commented May 29, 2023

Closing this issue as our stack scalingo-18 is deprecated and all customer's application are at least on scalingo-20.

@ipfaze ipfaze closed this as completed May 29, 2023
@ipfaze ipfaze closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants