Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance enhancements to 2-stage method #69

Closed
ChrisRackauckas opened this issue Mar 13, 2018 · 0 comments · Fixed by #137
Closed

Performance enhancements to 2-stage method #69

ChrisRackauckas opened this issue Mar 13, 2018 · 0 comments · Fixed by #137

Comments

@ChrisRackauckas
Copy link
Member

There's a few things that I can see.

There can be a view here:

https://github.com/JuliaDiffEq/DiffEqParamEstim.jl/blob/master/src/two_stage_method.jl#L95

We should probably transpose this earlier:

https://github.com/JuliaDiffEq/DiffEqParamEstim.jl/blob/master/src/two_stage_method.jl#L98

The cost function could also be deconstructed like the build_loss_objective in order to be more efficient.

https://github.com/JuliaDiffEq/DiffEqParamEstim.jl/blob/master/src/two_stage_method.jl#L96

Those copies could go away and this could be pre-cached
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize the two-stage method cost function SciML/DiffEqParamEstim.jl
1 participant
@ChrisRackauckas