Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add images in given order #63

Closed
wbrtm opened this issue Apr 26, 2022 · 4 comments
Closed

Add images in given order #63

wbrtm opened this issue Apr 26, 2022 · 4 comments

Comments

@wbrtm
Copy link
Contributor

wbrtm commented Apr 26, 2022

If there are more than one source paths (wildcard patterns) given in an ad file, the images are not added in that specific order.
@sebthom
Copy link
Contributor

sebthom commented Apr 26, 2022

Images are sorted by name.

@wbrtm
Copy link
Contributor Author

wbrtm commented Apr 26, 2022

Tanks for the fast reply. So this is intentional? Then I would try to tweak this only for myself.
It does make sense to me to sort by name if there is one path/pattern given. If there are more not so much. Might be specific to my use case though.

@sebthom
Copy link
Contributor

sebthom commented Apr 26, 2022

You can provide a PR where the images are sorted per path if you want.

@wbrtm
Copy link
Contributor Author

wbrtm commented Apr 27, 2022 •
edited
Loading

I opened a PR for an untested commit #65

@sebthom sebthom closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebthom @wbrtm