Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are uploaded in the wrong order #72

Closed
DreckSoft opened this issue May 6, 2022 · 6 comments
Closed

Images are uploaded in the wrong order #72

DreckSoft opened this issue May 6, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@DreckSoft
Copy link
Contributor

Seems the method of sorting the images has changed. Now they are uploaded in the wrong order.

I specifies
- img_.jpg
- img_
.JPG
- img_.jpeg
- img_
.JPEG
- img_.png
- img_
.PNG

If I now have
img_01.JPG
img_02.jpg

02 gets uploaded before 01.

I tried specifying somethin like img_*.[jJ][pP][eE]?[gG] but that doesn't work. Please revert the change.

@sebthom
Copy link
Contributor

sebthom commented May 6, 2022

I cannot reproduce this. Are the images all in the same directory?

@sebthom sebthom added the bug Something isn't working label May 6, 2022
@DreckSoft
Copy link
Contributor Author

Yes they are.

@DreckSoft
Copy link
Contributor Author

DreckSoft commented Jun 11, 2022

If i have
1 img_001.jpg
2 img_Arco...png
3 img_Z Korall....jpg
4 img_Z Madag....png

The upload order is 1,3,2,4
So unlike before where first a list of all pics was build and then uploaded in the alphabetical order regardless of the extension now the first specifies extension is used, everything with that extension is uploaded, then the second extension and so on.

The numbers before the images are just to clarify the order, they are not part of the filename.

@sebthom
Copy link
Contributor

sebthom commented Jun 11, 2022

Ok, so the issue is that you have multiple patterns to match different image extensions, like:

images:
 - myfolder/img_*.jpg
 - myfolder/img_*.png

I just committed a change that allows you to use extended globbing patterns to specify something like this:

images:
 - myfolder/img_*.{jpg,png}

The syntax is documented here https://facelessuser.github.io/wcmatch/glob/#syntax

@DreckSoft
Copy link
Contributor Author

Exactly.

Thanks, I'll try that next month when republishing.

@DreckSoft
Copy link
Contributor Author

That seems to work. Closing the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants