{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":628217514,"defaultBranch":"main","name":"redex","ownerLogin":"SeeYouOneDayDay","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-04-15T09:04:18.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/102854811?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1681549461.0085871","currentOid":""},"activityList":{"items":[{"before":"5c3cac5af591bc309c02f05f6a848480138db610","after":"06ee7a04e465da1d94e20bc093ba4d790827dec8","ref":"refs/heads/main","pushedAt":"2023-09-22T11:06:12.000Z","pushType":"push","commitsCount":326,"pusher":{"login":"hhhaiai","name":"hhhaiai","path":"/hhhaiai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5738285?s=80&v=4"},"commit":{"message":"Mark constructors as explicit\n\nSummary: Without the `explicit` keyword, we allow implicit conversions, which are error-prone. Let's fix that.\n\nReviewed By: arnaudvenet\n\nDifferential Revision: D49460439\n\nfbshipit-source-id: 143523b2876e1670323e0627b3587bd4abfa38e5","shortMessageHtmlLink":"Mark constructors as explicit"}},{"before":"88ac6424fee0d9dd5ba52674df44821fb949270c","after":"5c3cac5af591bc309c02f05f6a848480138db610","ref":"refs/heads/main","pushedAt":"2023-05-26T09:14:02.378Z","pushType":"push","commitsCount":98,"pusher":{"login":"hhhaiai","name":"hhhaiai","path":"/hhhaiai","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5738285?s=80&v=4"},"commit":{"message":"Resolve Miranda method reference to interface method\n\nSummary:\n# Backgound\n\nResolveRefsPass currently does not handle `invoke-virtual` Miranda method refs. Here is an example:\n```\ninterface I {\n  I foo();\n}\nabstract class Base {\n  I bar() {\n    // ...\n    return Base.foo();\n  }\n}\n\nfinal class Sub {\n  Override\n  I foo() { ... }\n}\n```\nThere is a miranda ref in `Base.bar()`, which is `invoke-virtual Base.foo()`. Currently we do not resolve the pure method ref to a method def. If we update the proto of the methods in the virtual scope (e.g., rtype specialization), the pure ref will be left out.\n\n# Solution\n\nWhen resolving method refs, if the Resolver fails to identify the def with `MethodSearch::Virtual`, retry with `MethodSearch::InterfaceVirtual`. If the ref is resolved to an interface def, rewrite the `invoke-virtual` to `invoke-interface`.\n\nReviewed By: agampe\n\nDifferential Revision: D46168062\n\nfbshipit-source-id: ec718b89032d04e8dd1f032e2f661a12895b9437","shortMessageHtmlLink":"Resolve Miranda method reference to interface method"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADhoivygA","startCursor":null,"endCursor":null}},"title":"Activity · SeeYouOneDayDay/redex"}