Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Server components over JMX #7761

Closed
shs96c opened this issue Nov 8, 2019 · 5 comments
Closed

Expose Server components over JMX #7761

shs96c opened this issue Nov 8, 2019 · 5 comments

Comments

@shs96c
Copy link
Member

shs96c commented Nov 8, 2019

We have the ManagedService annotation that used to be used expose the old selenium server via JMX. We should make the new server equally manageable.

@shs96c shs96c created this issue from a note in Selenium 4 (To do) Nov 8, 2019
@samueltauil
Copy link

I have interest on that to capture info from JMX and send to Prometheus then been able to build a custom chart

@amiluslu
Copy link
Contributor

Can you give me a little bit details about this issue ? If you give me a little bit details or clue, hints, I can start to fix.

@shs96c
Copy link
Member Author

shs96c commented Jun 3, 2020

@amiluslu we discussed this a little on the Slack channel. Do you still need some help getting started? I'm happy to provide more information if needed.

@pujagani
Copy link
Contributor

The older Grid had the following managed services and attributes.

  • Hub as a managed service.
    - Managed attribute :
    • Configuration
    • Session request count
  • DefaultRemoteProxy as managed service :
    - Managed attributes:
    • Proxy status (alive or no)
  • It extends the BaseRemoteProxy. BaseRemoteProxy has managed attributes:
    • Max number of sessions
    • Remote host
    • Total number of used slot
    • Total number of slots
    • Proxy status
    • Resource usage counted as (total no of used slots/ max number of sessions) * 100
    • The last session start time
  • SeleniumServer which is an implementation of GridNodeServer as a managed service.

The new Grid can have analogous managed services and attributes as follows:

  • Each server of grid servers can be a managed service :
    • DistributorServer
    • Hub server
    • SessionMapServer
    • Standalone server
    • NodeServer
    • RouterServer
    • NewSessionQueuer Server
    • EventBus
  • All above-listed components share config values in BaseServerOptions. These config values can be exposed as managed attributes.
  • Each individual components have additional component-specific attributes, which can be exposed as managed attributes.
  • The Distributor is aware of the Grid model. Grid specific attributes can be exposed by leveraging Grid model.
  • Information specific to a Node like max session count, slot information and availability can be obtained from via node implementations.

These are the observations and suggestions so so far. Can I get some help in understanding if this aligns with the intended feature? Please provide any other details I might have missed.

@diemol
Copy link
Member

diemol commented Dec 22, 2020

Fixed via #8838

@diemol diemol closed this as completed Dec 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants