Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpectedCondition.jsReturnsValue documentation does not correlate with implementation #8882

Closed
npapp opened this issue Nov 17, 2020 · 1 comment
Assignees
Labels

Comments

@npapp
Copy link

npapp commented Nov 17, 2020

🐛 Bug Report

ExpectedCondition.jsReturnsValue documentation states that it returns true if the given script returns string but it returns the value returned by the script (I assume) if it's not an empty string or list, otherwise null.

public static ExpectedCondition<Object> jsReturnsValue(final String javaScript) {

I think either the documentation or the implementation should be fixed.

@ghost ghost added the needs-triaging label Nov 17, 2020
@pujagani pujagani self-assigned this Dec 28, 2020
@pujagani
Copy link
Contributor

Thank you for pointing this out. The documentation needs to be fixed. The method is used to check if the javascript returns an object (mostly string).

@diemol diemol closed this as completed in bf2fc56 Dec 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants