refactor: clean up file diff iterator logic #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the "Recreated" type, since it is too difficult to tell the difference between it and "Created".
- Added checks in most recent logs for files that existed before but not now. - Added `HoardFileDiff::Nonexistent` to indicate a file that is listed in the config but has never existed in Hoard. - Added `ItemOperation::DoesNotExist` to correspond with the above. - Because of these changes, a couple of "unreachable" branches became reachable, so that got fixed too.
Permissions checks were among the last few things to get test coverage, but there is not a reliable way to maintain permissions across filesystems and/or operating systems, particularly when Windows is involved. This removes permissions support. In the future, there will be a change to apply permissions on restore.
✅ Deploy Preview for hoard-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 90.49% 91.80% +1.31%
==========================================
Files 69 73 +4
Lines 5037 5808 +771
==========================================
+ Hits 4558 5332 +774
+ Misses 479 476 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #110 and #99.