#26: Prevent file footguns #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the relevant `LastPaths` types, implementing checks for changed paths. Also includes a `--force` flag for allowing the operation to continue without the check.
Rather than creating a sum of scores, which can easily have collisions
between different sets of scores, keep track of every score in the tree
path.
A path is considered a better match using the following algorithm:
1. The path with more nodes is better.
2. If paths are equal length, the one with more higher numbers is
better.
- Of `A: [7, 3, 2, 1]` and `B: [5, 4, 3, 2]`, `B` is the better match
because it generally has higher scores than `A`.
3. If the paths have equal numbers of higher scores, abort with error.
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 60.84% 56.83% -4.01%
==========================================
Files 16 17 +1
Lines 1637 1990 +353
Branches 395 509 +114
==========================================
+ Hits 996 1131 +135
- Misses 355 517 +162
- Partials 286 342 +56
Continue to review full report at Codecov.
|
Shadow53
commented
Aug 28, 2021
|
Tests pass, codecov does not consider the Python script for coverage (which provides more coverage than unit tests could, imo), and I am content with the state of the codebase at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26 and #28.
Implements two checks:
Check 1: Last Paths
This check validates that the paths being used in the current operation are the same as the most recent operation on that hoard. If the paths are different, this may constitute an unintentional environment change. Users can double-check that the paths being used are the intended ones, and then use the
--forceflag to make the operation go through.Check 2: Remote Operations
This check uses (hopefully synchronized) records from other systems to determine if the most recent update of a file happened locally or on a remote system. If it happened on a remote system, any backup operation is cancelled to prevent accidentally overwriting remote changes. Again, this check can be disabled using the
--forceflag.