Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand env variables in path_exists for consistency #54

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

Shadow53
Copy link
Owner

Resolves #49.

CI tests do not seem necessary. The unit tests added should be enough to cover it.

@Shadow53 Shadow53 added this to the 0.3.1 milestone Oct 13, 2021
@netlify
Copy link

netlify bot commented Oct 13, 2021

✔️ Deploy Preview for hoard-docs ready!

🔨 Explore the source changes: aa6ccef

🔍 Inspect the deploy log: https://app.netlify.com/sites/hoard-docs/deploys/61663dc313aa0f0007ffda2f

😎 Browse the preview: https://deploy-preview-54--hoard-docs.netlify.app

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #54 (aa6ccef) into main (a9db936) will increase coverage by 0.40%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   49.63%   50.03%   +0.40%     
==========================================
  Files          23       23              
  Lines        1245     1259      +14     
==========================================
+ Hits          618      630      +12     
- Misses        627      629       +2     
Impacted Files Coverage Δ
src/config/builder/environment/path.rs 90.00% <85.71%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e201e...aa6ccef. Read the comment docs.

@Shadow53 Shadow53 merged commit ecea695 into main Oct 13, 2021
@Shadow53 Shadow53 deleted the 49-expand-env-in-path-exists branch October 13, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand environment variables in path_exists
1 participant