Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: parse glob patterns when reading config, not after #60

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

Shadow53
Copy link
Owner

Resolves #58 by parsing ignore patterns as glob::Pattern when the configuration file is deserialized instead of when the ignore patterns get used.

@netlify
Copy link

netlify bot commented Nov 14, 2021

✔️ Deploy Preview for hoard-docs ready!

🔨 Explore the source changes: b3cf4e6

🔍 Inspect the deploy log: https://app.netlify.com/sites/hoard-docs/deploys/61908ec1f97b5e0007206a80

😎 Browse the preview: https://deploy-preview-60--hoard-docs.netlify.app

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #60 (b3cf4e6) into main (f5eb564) will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   47.72%   48.12%   +0.39%     
==========================================
  Files          23       23              
  Lines        1320     1332      +12     
==========================================
+ Hits          630      641      +11     
- Misses        690      691       +1     
Impacted Files Coverage Δ
src/filters/mod.rs 60.00% <ø> (ø)
src/config/builder/hoard.rs 73.41% <100.00%> (+9.01%) ⬆️
src/filters/ignore.rs 40.00% <100.00%> (-26.67%) ⬇️
src/config/builder/envtrie.rs 88.69% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5eb564...b3cf4e6. Read the comment docs.

@Shadow53 Shadow53 added this to the 0.3.1 milestone Nov 21, 2021
@Shadow53 Shadow53 merged commit 796d64f into main Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse ignore globs at deserialization
1 participant