Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage alternatives to assert.fail #79

Closed
GoodForOneFare opened this issue May 12, 2016 · 1 comment
Closed

Discourage alternatives to assert.fail #79

GoodForOneFare opened this issue May 12, 2016 · 1 comment
Assignees
@GoodForOneFare
Labels
new-rule

Comments

@GoodForOneFare
Copy link
Member

Code like assert.ok(false, 'error message') should be flagged as an error. If possible, add a fix option to translate to assert.fail('error message').
@lemonmade
Copy link
Member

In theory fixable, but I wouldn't bother as it would be a bit of a pain to replace the correct text range.

@GoodForOneFare GoodForOneFare mentioned this issue Jun 6, 2016
Open
@GoodForOneFare GoodForOneFare self-assigned this Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GoodForOneFare GoodForOneFare

Labels
new-rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GoodForOneFare @lemonmade