Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

Remove -base suffix from base color variables #16

Closed
harbify opened this issue Apr 19, 2018 · 1 comment
Closed

Remove -base suffix from base color variables #16

harbify opened this issue Apr 19, 2018 · 1 comment
Labels
breaking change enhancement

Comments

@harbify
Copy link

harbify commented Apr 19, 2018

Right now we use variable names like $color-ink-base for the default Ink color value. We should remove the -base suffix because it's confusing. It should follow the color name and the way it's used in the color function: color('ink').
@kaelig kaelig mentioned this issue May 25, 2018
Merged
@kaelig kaelig mentioned this issue Jun 13, 2018
Merged
@kaelig
Copy link
Contributor

kaelig commented Jul 11, 2018

Closed in #22. Thanks for the suggestion!

@kaelig kaelig closed this as completed Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaelig @harbify