Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Support linked packages in extensions via esbuild #254

Open
kumar303 opened this issue Mar 23, 2022 · 2 comments
Open

Support linked packages in extensions via esbuild #254

kumar303 opened this issue Mar 23, 2022 · 2 comments

Comments

@kumar303
Copy link
Contributor

I ran into this bug when trying to use yarn link in my extension (example). Using linked packages is important for Checkout development (internally at Shopify) so we can preview some upcoming checkout-web packages.

I think an upgrade of esbuild will fix it? I haven't tried it yet, just wanted to file an issue.

@vividviolet
Copy link
Member

Thanks for flagging this. We did encounter this but didn't realize it's an esbuild issue as I believe we also ran into this in Web using webpack

@kumar303
Copy link
Contributor Author

After filing this, I realized linking shopify-cli-extensions was working fine so ... that's odd 🤔

In extension code, this was working for me:

pushd ~/src/github.com/Shopify/shopify-cli-extensions/packages/shopify-cli-extensions
yarn link
popd
yarn link @shopify/shopify-cli-extensions

...but this was not:

pushd ~/src/github.com/Shopify/checkout-web/packages/checkout-ui-extensions-react
yarn link
popd
yarn link @shopify/checkout-ui-extensions-react

In any case, @jamesvidler tried upgrading esbuild and got past this specific error ✨

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants