Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing skins in pets section #1686

Closed
wants to merge 24 commits into from
Closed

feat: add missing skins in pets section #1686

wants to merge 24 commits into from

Conversation

DuckySoLucky
Copy link
Member

@DuckySoLucky DuckySoLucky commented Sep 27, 2022 •
edited
Loading

Description

Closes #982

Examples (Scroll down)

Refraction
image
DuckySoSkilled
image
DeathStreeks
image

@project-bot project-bot bot added this to To do in Issues and PRs Sep 27, 2022
@dukio dukio added the needs testing Pull requests that need testing before proceeding further label Oct 6, 2022
@dukio dukio added dont merge yet For pull requests not meant to be merged yet for a reason and removed needs testing Pull requests that need testing before proceeding further labels Oct 6, 2022
dukio
dukio suggested changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@dukio dukio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See DuckySoLucky#9
There's still work to be done after the PR merge

@dukio dukio added the waiting Pull requests or issues that are waiting for something label Oct 7, 2022
@dukio dukio added needs testing Pull requests that need testing before proceeding further and removed dont merge yet For pull requests not meant to be merged yet for a reason waiting Pull requests or issues that are waiting for something labels Oct 9, 2022
@dukio dukio added the waiting Pull requests or issues that are waiting for something label Oct 9, 2022
@dukio
Copy link
Contributor

dukio commented Oct 9, 2022

I'll add the waiting tag cause the typescript issues needs to be resolved (you or someone else)

@DuckySoLucky
Copy link
Member Author

I'll add the waiting tag cause the typescript issues needs to be resolved (you or someone else)

Solved

dukio
dukio suggested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@dukio dukio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is good but I would improve it like discussed here: https://discord.com/channels/738971489411399761/820755886262976553/1029145305268105246 (private channel)

@DuckySoLucky
Copy link
Member Author

Added new Kuudra tiers
image
Added Description to Item Skins
image
image
image

@metalcupcake5 metalcupcake5 removed needs testing Pull requests that need testing before proceeding further waiting Pull requests or issues that are waiting for something labels Dec 6, 2022
@github-actions github-actions bot added the has conflicts when a PR has conflicts label Mar 12, 2023
Issues and PRs automation moved this from To do to Done Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalcupcake5 metalcupcake5 metalcupcake5 approved these changes

@dukio dukio Awaiting requested review from dukio

@MartinNemi03 MartinNemi03 Awaiting requested review from MartinNemi03

Assignees
No one assigned
Labels
has conflicts when a PR has conflicts
Projects
Issues and PRs
  
Done
Status of Pull Requests
Status: Drafts/Waiting
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing pet skins section
3 participants
@DuckySoLucky @dukio @metalcupcake5