Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime checks failing on esp32 #2834

Closed
mikee47 opened this issue Jun 24, 2024 · 1 comment · Fixed by #2835
Closed

DateTime checks failing on esp32 #2834

mikee47 opened this issue Jun 24, 2024 · 1 comment · Fixed by #2835
Labels

Comments

@mikee47
Copy link
Contributor

mikee47 commented Jun 24, 2024

Running HostTests on esp32 I'm getting a very odd failure in DateTime checks. No problems with esp8266 or host builds (32/64-bit). Something is going on with int32 / int64 values. It's almost like there's a bug in the 64-bit routines somewhere. But that's jumping to conclusions.

RefDate 31/01/2024 00:00:00
Check 24/02/1903 17:31:44 (0s, 0m 0h, 5540d)
Got   24/02/1903 17:31:44, diff 4294967296
FAIL: refTime == calcTime (2185315200, -2109652096)
FAIL in `DateTimeTest::checkSetTime(const FSTR::Array<{anonymous}::TestDate>&, bool)::<lambda(int, int, int, int)>`

Converting to hex we have:

refTime: 0x82414380
calcTime: 0xffffffff82414380

@mikee47
Copy link
Contributor Author

mikee47 commented Jun 24, 2024

Yep, was linking in ROM functions which are 32-bit-only so get truncated values.

@mikee47 mikee47 added Bug and removed Bug labels Jun 25, 2024
@slaff slaff closed this as completed in 7806972 Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant