Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downsides of forking 3rd party repositories here #5

Open
mschubert opened this issue Feb 9, 2018 · 4 comments
Open

Downsides of forking 3rd party repositories here #5

mschubert opened this issue Feb 9, 2018 · 4 comments

Comments

@mschubert
Copy link

mschubert commented Feb 9, 2018

If a repository is forked from another source, its issues will be disabled by default.

If I then report an issue with the profile to the original source, this will not be automatically propagated to this collection.

Wouldn't it be better to move repositories here instead of forking them? (and only forking if they change)

Authors would still get credit (because they are listed as commiters)

(Anyway, this is just a suggestion so feel free to ignore)

@johanneskoester
Copy link
Contributor

Mhm, wait, we have issues for the pbs-torque repo, which is forked...

@johanneskoester
Copy link
Contributor

I have to enable them. Now we also have them for slurm. Thanks for making me aware of this!

@mschubert
Copy link
Author

Yes, then the question is if you want to have separate development workflows or one.

Example:

I sent a PR to https://github.com/percyfal/slurm to add more detailed installation instructions. Now you fixed them here, which is great, but you'll have a conflict if the original repo accepts the PR.

This is why I thought it would make most sense to ask original maintainers if they agree with moving repos to the Snakemake-Profiles user.

@johanneskoester
Copy link
Contributor

Yes, we can do that as well, you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants