Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve npm override support #222

Closed
jdalton opened this issue Oct 11, 2024 · 4 comments
Closed

Improve npm override support #222

jdalton opened this issue Oct 11, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jdalton
Copy link
Collaborator

jdalton commented Oct 11, 2024

See npm/cli#7025 (comment)

Because @socketsecurity/cli wraps npm we have the opportunity to patch its overrides behavior.
@AlonNavon thoughtfully put their learnings so far in npm/cli#7025.

@jdalton jdalton added help wanted Extra attention is needed enhancement New feature or request labels Oct 11, 2024
@jdalton jdalton self-assigned this Oct 11, 2024
@jdalton
Copy link
Collaborator Author

jdalton commented Oct 11, 2024

@AlonNavon I've backed channeled a bit with npm folks. Let's see in the next week or so. There may be more engagement on your PR to push it through.

@bcomnes
Copy link
Member

bcomnes commented Oct 11, 2024

Any clue what the holdup is?

@jdalton
Copy link
Collaborator Author

jdalton commented Oct 11, 2024

@bcomnes Lots of users and things to do. Some stuff falls through the cracks.

Update:

A npm maintainer replied ✨ npm/cli#7025 (comment) ❤️
I'll help review over there and implement a quick and dirty solution here.

@jdalton
Copy link
Collaborator Author

jdalton commented Oct 15, 2024

Fixed via 644ed42, 28e5b3d, and c2ced1a.

@jdalton jdalton closed this as completed Oct 15, 2024
@jdalton jdalton removed the help wanted Extra attention is needed label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants