Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Rule 942230: False positive #1607

Open
Taiki-San opened this issue Oct 24, 2019 · 3 comments
Open

Rule 942230: False positive #1607

Taiki-San opened this issue Oct 24, 2019 · 3 comments
Assignees
Labels
False Positive PR available this issue is referenced by an active pull request

Comments

@Taiki-San
Copy link
Contributor

Type of Issue

False positive

Description

I think this rule has a similar issue to #1580 and will very aggressively match weird patterns like behavingbadly/.
I suspect the simplest fix would be to add \b right and left.

Confirmation

[x] I have removed any personal data (email addresses, IP addresses,
passwords, domain names) from any logs posted.

@ghost
Copy link

ghost commented Dec 5, 2019

Also experiencing this same issue -- catching "having pain." and "having tooth #30". This is way overly aggressive regex.
Any word on when someone might fix this?

@dune73
Copy link
Contributor

dune73 commented Dec 5, 2019

Sorry for the inconvenience, guys. This is annoying. And the examples you give clearly underline the fact, this is overly aggressive.

@dentaldeveloper : Are you able to write a rule exclusion as a workaround?

One problem with 942230 is that we only have 1 official unit test for this rule. So it is possible that we add a \b and stop detecting the things this is made for.

However, I have over 500 attacking payloads that this rule detects. And many of them could be made into FTW tests. Then we could change the rule and use these checks to see the payloads are still detected.

Is one of you guys interested in doing that? I could provide you with the payloads via direct message.

@ghost
Copy link

ghost commented Dec 6, 2019

Thanks for the quick response. I will probably write a workaround for this until it can be fixed. Unfortunately, I'm not familiar with the WFT framework for testing -- so I won't be able to help at this time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
False Positive PR available this issue is referenced by an active pull request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants