Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the public API and currently unused types #699

Open
armiol opened this issue Dec 9, 2021 · 0 comments
Open

Review the public API and currently unused types #699

armiol opened this issue Dec 9, 2021 · 0 comments
Assignees

Comments

@armiol
Copy link
Collaborator

armiol commented Dec 9, 2021

After splitting base into several repositories, some of the types and some of the methods became unused. Also, many endpoints are over-exposed — typically, being public instead of package-private.

During the migration to Java 11, the "unused" warnings were suppressed with

@SuppressWarnings("unused") /* Part of the public API. */

The over-exposed methods were left intact.

When addressing this issue, one should review the "unused" and over-exposed pieces. And either remove/hide them, or cover with the corresponding tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants