Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include NPM dependencies into license reports #301

Open
yevhenii-nadtochii opened this issue Nov 25, 2021 · 0 comments
Open

Include NPM dependencies into license reports #301

yevhenii-nadtochii opened this issue Nov 25, 2021 · 0 comments
Labels
dependencies An issue on updating dependencies enhancement New feature or request

Comments

@yevhenii-nadtochii
Copy link
Contributor

yevhenii-nadtochii commented Nov 25, 2021

Currently, JavaScript modules of web repository don't include their NPM dependencies into project's license-report.md.

The corresponding task for that is already assembled and ready-to-use — npmLicenseReport. But its linkage to the main task responsible for license reporting is temporarily commented out.

io.spine.internal.gradle.javascript.task.impl.LicenseReport.kt:

import io.spine.internal.gradle.report.license.generateLicenseReport
import io.spine.internal.gradle.javascript.task.JsTaskRegistering

// ...

fun JsTaskRegistering.licenseReport() {
//    generateLicenseReport.finalizedBy(
//        npmLicenseReport()
//    )
}

The problem is that formatting of an NPM dependency differs from the Java's one. Hence, when the task is enabled, rendering of Spine / Open-Source Libraries and Licenses page should be adjusted, as this page renders license-report.md files.

@yevhenii-nadtochii yevhenii-nadtochii added the enhancement New feature or request label Nov 25, 2021
@yevhenii-nadtochii yevhenii-nadtochii changed the title Include NPM dependencies into a license report Include NPM dependencies into license reports Nov 25, 2021
@alexander-yevsyukov alexander-yevsyukov added the dependencies An issue on updating dependencies label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies An issue on updating dependencies enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants