Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing DS key generation schemas #145

Open
yuri-sergiichuk opened this issue Feb 26, 2020 · 0 comments
Open

Consider changing DS key generation schemas #145

yuri-sergiichuk opened this issue Feb 26, 2020 · 0 comments
Labels
enhancement

Comments

@yuri-sergiichuk
Copy link
Contributor

yuri-sergiichuk commented Feb 26, 2020 •
edited
Loading

Having the same Datastore key prefix is considered a bad practice that leads to the Datastore performance degradation.

We now have such prefixes for LifecycleFlags in DsAggregateStorage. The other prefix-based key is used for Snapshots.

In DsProjectionStorage we also have such a prefix for last handled event time. An additional note for DsProjectionStorage is that we use google.protobuf.Timestamp as a kind for the last event timestamp which is misleading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuri-sergiichuk