Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow down an excessive visibility of AbstractBackend members #47

Open
yevhenii-nadtochii opened this issue Sep 14, 2023 · 0 comments
Open

Comments

@yevhenii-nadtochii
Copy link
Collaborator

I've extended visibility of the class constructor and the factory method for forcing loggers to protected.

These are needed in tests to create stub implementations. Having them package-private forces to declare stubs right in spec files, which is inconvenient if that stubs are pretty big.

When migrating this class to Kotlin, these methods should become internal because real implementations should not see these methods as open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant