Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RejectionGenPlugin ignores rejections from protobuf()-scoped dependencies #47

Open
yuri-sergiichuk opened this issue Jun 22, 2021 · 2 comments
Open

RejectionGenPlugin ignores rejections from protobuf()-scoped dependencies #47

yuri-sergiichuk opened this issue Jun 22, 2021 · 2 comments
Assignees
@alexander-yevsyukov

Comments

@yuri-sergiichuk
Copy link
Contributor

yuri-sergiichuk commented Jun 22, 2021 •
edited
Loading

The current behavior of the RejectionGenPlugin is to generate rejections only from rejections.proto files that belong to the current module.

Such behavior does not allow having shared proto-only modules while rejections are not going to be generated. Other generation tasks are working just fine (e.g. messages in _events.proto are considered as event messages, etc.).
@armiol
Copy link
Contributor

armiol commented Jun 22, 2021

@dmdashenkov PTAL.

@alexander-yevsyukov alexander-yevsyukov transferred this issue from SpineEventEngine/base Sep 21, 2022
@armiol
Copy link
Contributor

armiol commented Jun 9, 2023

@alexander-yevsyukov this issue probably relates to your current development plans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexander-yevsyukov alexander-yevsyukov

Labels
None yet
Projects
v2.0
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@armiol @alexander-yevsyukov @yuri-sergiichuk