Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Plugin order is not consistent after updating plugins #513

Closed
3 of 4 tasks
PartyWumpus opened this issue Jul 26, 2023 · 2 comments
Closed
3 of 4 tasks

[BUG] Plugin order is not consistent after updating plugins #513

PartyWumpus opened this issue Jul 26, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@PartyWumpus
Copy link
Member

Please confirm

  • I have searched existing issues
  • This issue is not a duplicate of an existing one
  • I have checked the common issues section in the readme file
  • I have attached logs to this bug report (failure to include logs will mean your issue will not be responded too).

Bug Report Description

After a plugin is updated, the plugin order is succesfully restored to the order it should be, but then after the steam client is restarted or if decky is restarted, the updated plugins move to the bottom. If the order is manually changed before the client restarts, it'll work fine.

The frontend has the correct order, but the backend does not. When a plugin is updated the loader.json's pluginOrder list first loses that plugin from the list and then it appears again at the bottom. This is likely fixable either by putting the same code that fixes the order in the frontend into the backend as well, or just saving the order from the frontend whenever a plugin is updated or possibly removing the code that's incorrectly saving to the loader.json file on a plugin update.

Expected Behaviour

The order should be consistent.

SteamOS version

SteamOS 3.5 Main

Selected Update Channel

Stable

Have you modified the read-only filesystem at any point?

Yes, not relevant

Logs

not relevant

@PartyWumpus PartyWumpus added the bug Something isn't working label Jul 26, 2023
@PartyWumpus PartyWumpus self-assigned this Jul 26, 2023
@btabaska
Copy link

btabaska commented Aug 2, 2023

#522 Pull Request to add backend settings sync to plugin order like notification settings uses.

@nabel0
Copy link

nabel0 commented Aug 24, 2023

I can confirm this...Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants